Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling directories #3351

Closed
foolip opened this issue Jun 7, 2023 · 4 comments · Fixed by #3447
Closed

Labeling directories #3351

foolip opened this issue Jun 7, 2023 · 4 comments · Fixed by #3447
Assignees
Labels
enhancement New feature or request

Comments

@foolip
Copy link
Member

foolip commented Jun 7, 2023

For web-platform-tests/interop-accessibility#44, it would be useful to be able to label directories, to be able to replace this query of multiple directories and one test: path:/accessibility or path:/accname or path:/html-aam or path:/wai-aria or path:/svg-aam or path:/graphics-aria or path:/graphics-aam or path:/dpub-aam or path:/html/dom/aria-element-reflection.html

Labeling is currently done in wpt-metadata with support in the wpt.fyi UI to add labels to tests, but not directories.

Option 1: We already support linking a bug to a whole directory in wpt-metadata (example) and it we could do the same for labels. web-platform-tests/wpt-metadata#4303 is an example of what this would look like in wpt-metadata.

Option 2: We could support labels in WPT itself, via its META.yml files. That would make this similar to #372, which is about spec links extracted from WPT. @KyleJu is working on this now.

In either case, the idea is that label:accessibility would work as a search atom, and it would not be necessary to individually label all of the tests in each directory.

@foolip
Copy link
Member Author

foolip commented Jun 7, 2023

@cookiecrook did web-platform-tests/wpt-metadata#4297, so no need for my draft web-platform-tests/wpt-metadata#4303.

It looks from https://wpt.fyi/results/?label=master&label=experimental&aligned&q=label%3Aa11y like this doesn't work in the search cache. @KyleJu can you help check how labels and bugs are different? Given that we have triaged:chrome which is based on bug links I guess the search cache does understand '*' as a wildcard for tests in some contexts, but not for labels?

@KyleJu
Copy link
Collaborator

KyleJu commented Jun 7, 2023

@cookiecrook did web-platform-tests/wpt-metadata#4297, so no need for my draft web-platform-tests/wpt-metadata#4303.

It looks from https://wpt.fyi/results/?label=master&label=experimental&aligned&q=label%3Aa11y like this doesn't work in the search cache. @KyleJu can you help check how labels and bugs are different? Given that we have triaged:chrome which is based on bug links I guess the search cache does understand '*' as a wildcard for tests in some contexts, but not for labels?

Wildcard has not been implemented in label yet, but it shouldn't be huge amount of work. Let me try to get to it at the end of this month. Thanks for bringing it to my attention :)

@KyleJu
Copy link
Collaborator

KyleJu commented Aug 10, 2023

Note: we will go with option 1 proposed by the issue author. It includes supporting wildcards on the wpt.fyi UI and searchcache

@KyleJu
Copy link
Collaborator

KyleJu commented Aug 10, 2023

Once #3447, this feature will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants