Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View source on GitHub" can be broken while loading #446

Open
foolip opened this issue Aug 15, 2018 · 2 comments
Open

"View source on GitHub" can be broken while loading #446

foolip opened this issue Aug 15, 2018 · 2 comments
Labels
enhancement New feature or request front-end

Comments

@foolip
Copy link
Member

foolip commented Aug 15, 2018

https://staging.wpt.fyi/results/gamepad/idlharness.window.html?label=stable initially links to https://github.com/web-platform-tests/wpt/blob/master/gamepad/idlharness.window.html when loading, but after loading the link is updated to https://github.com/web-platform-tests/wpt/blob/master/gamepad/idlharness.window.js, which works.

The fixuping is slow enough that I encountered it without trying to stress test. Hiding the link until it's been updated would work.

@lukebjerring
Copy link
Contributor

Hiding the link would actually cause a bit of a jank, which I'm not too happy causing. Maybe a non-link placeholder, like

Fetching GitHub source...

?

@foolip
Copy link
Member Author

foolip commented Sep 28, 2018

Yeah, that'd work. Just not adding an href attribute until we have the final URL would also do the trick, and probably less noticeable in the typical case where people aren't focuses on this link.

@lukebjerring lukebjerring added enhancement New feature or request front-end labels Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end
Projects
None yet
Development

No branches or pull requests

2 participants