Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add link to log files #560

Open
whimboo opened this issue Sep 17, 2018 · 4 comments
Open

Please add link to log files #560

whimboo opened this issue Sep 17, 2018 · 4 comments

Comments

@whimboo
Copy link

whimboo commented Sep 17, 2018

When you check the following results for Firefox it is not clear what's wrong. Given the missing details and no link to any log, it makes it impossible for me to get this problem fixed.

https://wpt.fyi/results/webdriver/tests/set_window_rect/set.py?label=experimental

It would be great if there were links to the log files as produced by the currently displayed job results.

@Hexcles
Copy link
Member

Hexcles commented Sep 17, 2018

Unfortunately I don't think our BuildBot runner actually preserves the logs? @jugglinmike

However, given that Taskcluster is looking good and it does have easily linkable logs, I'm not sure if we want to spend much time capturing logs from BuildBot.

But yeah, for Taskcluster, I think it'd be a good idea to store the links to the original task groups which would provide a lot of useful information.

@jugglinmike
Copy link
Contributor

Buildbot does indeed persist the logs--here's one from March. To report this to wpt.fyi, tasks would need to introspect their own ID's. I don't know if that's supported, but I could look into it.

I think the wpt.fyi feature would be implemented in the same way for Buildbot and Taskcluster. The uploaders just need to be able to include a URL in the results payload. Does that sound right to you. @Hexcles?

@Hexcles
Copy link
Member

Hexcles commented Sep 17, 2018

Yes, that's the idea, @jugglinmike . Let me know when you figure out whether it's easy to get the task ID within a task.

@jugglinmike
Copy link
Contributor

@Hexcles confirmed that the necessary API is available in Buildbot. We can annotate results with links to the "trigger" build. This is a slightly farther removed than I'd like since it includes tasks for, e.g. Chrome stable and Chrome experimental, but it is the most direct URL we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants