Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Improvements to deploy script #478

Open
11 tasks
molant opened this issue May 1, 2019 · 0 comments
Open
11 tasks

Improvements to deploy script #478

molant opened this issue May 1, 2019 · 0 comments

Comments

@molant
Copy link
Member

molant commented May 1, 2019

List of things we could do to improve the experience with deploy.sh

  • Parameters validation. E.g.: I arrived to step 6 when it told me registry_name wasn't valid
  • Length of password for DB is not validated. It says between 12 and 32 but you can type anything
  • Look into using the default version of Kubernetes instead of a hardcoded one that could be removed at any time
  • Use the same region for all resources via the parameter, right now it's hardcoded in a few places
  • If role assignment fails after 3 tries, the process continues, we should do better error validation
  • The output isn't very nice TBH...
  • Even though the script does some checking to see if the user is logged in, it doesn't work and you have to manually do az login before running the script
  • If something fails, ask if we want to do clean up of the resources (delete resource group and service principal)
  • From time to time there are errors with k8s with network operations. The solution for now seems to disable httpApplicationRouting in the template
  • Tell how much each task has taken (and total)
  • Maybe we should think about migrating this to powershell now that's crossplatform or node with listr or something like that to have a nicer output?

@utsavized, @sarvaje FYI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant