-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quirk: bare <li> have list-style-position: inside #10959
base: main
Are you sure you want to change the base?
Conversation
Should this go to https://quirks.spec.whatwg.org/ instead of HTML? |
@Loirooriol no, HTML already has quirks mode style rules like this. Eventually, all quirks should be upstreamed to the appropriate spec instead of being defined in a delta spec. |
Marking "do not merge yet" for #10958 (comment) (also see earlier comments). |
See web compat analysis: #10958 (comment)
I've updated this PR to also apply this behavior in standards mode and to include |
Slight preference to align on current WebKit / Firefox Nightly behavior (just quirks and no dir / menu) fwiw... There may be other compat impact of making the change to computed styles in standards mode so if we can get away with it seems preferable, specially if the visual impact is minimal |
(Plus those selectors are not particularly cheap) |
This reverts commit 57f5ab7.
I've changed this again to only apply in quirks mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, seems fine to put dir/menu on my end again. @nt1m given the discussions above does it seems reasonable to you?
I doubt we really need I could live either way on including |
For example http://old.lawjusticediv.gov.bd/ with ![]() In WebKit the marker is on the same line anyway, but that seems like a bug, if I understand the spec correctly.
https://drafts.csswg.org/css-lists/#valdef-list-style-position-inside Demo: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/13478 ![]() Apart from making a few pages render better, I think it also makes more sense to make https://software.hixie.ch/utilities/js/live-dom-viewer/saved/13479 |
I see now that the above page is in standards mode, but I intentionally analyzed more standards mode pages than quirks mode pages (to understand impact of quirks-mode-only vs all modes). |
Yes, WebKit doesn't treat inside markers as normal inline boxes. See relevant discussion: w3c/csswg-drafts#5276 (comment) |
Fixes #10958.
(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )