Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting loading=eager should be less COMEFROM-ey #5547

Closed
domfarolino opened this issue May 15, 2020 · 1 comment
Closed

Setting loading=eager should be less COMEFROM-ey #5547

domfarolino opened this issue May 15, 2020 · 1 comment
Assignees
Labels
clarification Standard could be clearer topic: img

Comments

@domfarolino
Copy link
Member

Currently a loading=lazy image is deferred until the will lazy load image steps return false, and these steps return true as long as an image's loading attribute is in the Lazy state. This means right when an element's loading attribute is set to the Eager state, these steps will return false.

While that's not too COMEFROM-ey (since we're explicitly invoking the steps that apparently observe the state of the loading attribute), I think it would be clearer if we explicitly resumed the #updating-the-image-data algorithm when the loading attribute gets set to the Eager state.

This is filed as a follow-up to #5510 (comment), and I'll take care of it when that PR lands.

@domfarolino
Copy link
Member Author

Closed by by #5573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: img
Development

No branches or pull requests

1 participant