-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing lo0 parent should have a better error message #23
Comments
I am thinking about refactoring Errors all along. Introducing a DeviceError which can get caught on device loop level and gets the device ignored and the error message printed, a InterfaceError for the interface loop which gets the interface ignored and a FatalError which stops execution and does not create artifacts. |
Do we want to wait until we start refactoring everything, or do you want to implement it now ? There's only one portion of the RouterSerializer for which we still have to write tests (QoS stuff iirc), but idk how urgent this change is, and if we can wait for the refactor to be completed. |
Include a print error message for now and we will rework it later. |
Currently we have this error when a device has no lo0 parent:
we should introduce a better error message for this specific case, such as the operator can quickly identify the issue and correct it from the datasource
also, a test case would be needed to make sure future refactoring does not omit this.
The text was updated successfully, but these errors were encountered: