Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Product errors when logged in with site credentials #14410

Open
joshheald opened this issue Nov 13, 2024 · 1 comment
Open

Handle Product errors when logged in with site credentials #14410

joshheald opened this issue Nov 13, 2024 · 1 comment
Labels
feature: product list Related to the product list. priority: low Not many people are affected or there’s a workaround, etc. type: bug A confirmed bug.

Comments

@joshheald
Copy link
Contributor

joshheald commented Nov 13, 2024

Description

There are various places in our code where we have special-case handling for DotcomError instances coming from a network request.

These may be used to give specific resolution advice to the users.

When logged in with site credentials, the networking stack will return NetworkError instances instead, and any specific resolution is unlikely to be shown.

We should check these areas, and if needed, handle the NetworkError as well.

Note that it might be best to do the error unwrapping in Yosemite, and return a specific error type to the app layer, so that we don't need to import these networking error types in the WooCommerce target.

Context: peaMlT-Zl-p2

Areas to check

  • ProductStore.synchronizeProducts (products API request error from invalid product type due to lack of extensions on the site.)
  • ProductStore ProductUpdateError init
  • ProductCategoryStore.synchronizeProductCategory categoryDoesNotExistRemotely

Relates to

#14409
#14374
#14365

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2024

Thanks for reporting! 👍

@joshheald joshheald added type: bug A confirmed bug. feature: product list Related to the product list. priority: low Not many people are affected or there’s a workaround, etc. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product list Related to the product list. priority: low Not many people are affected or there’s a workaround, etc. type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants