Fix positioning of toolbar in reader detail #21719
Open
+45
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sewhere (specifically, ReaderPostDetailFragment)
Generated by 🚫 Danger |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21719-0a42f54 | |
| Commit | 0a42f54 | |
| Direct Download | jetpack-prototype-build-pr21719-0a42f54.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21719-0a42f54 | |
| Commit | 0a42f54 | |
| Direct Download | wordpress-prototype-build-pr21719-0a42f54.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21719 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 2122 2122
Lines 99570 99570
Branches 15324 15324
=======================================
Hits 39247 39247
Misses 56844 56844
Partials 3479 3479 ☔ View full report in Codecov by Sentry. |
|
dcalhoun
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21718
Prior to this PR, the toolbar in reader detail was too low on Android 15 (Vanilla Ice Cream). The primary cause for this was not correctly consuming the window insets in
BaseAppCompatActivity, which meant whenReaderDetailFragmentadjusted the toolbar to account for the window insets, the insets were applied twice.Resolving this uncovered the fact that
BaseAppCompatActivitywas more involved that it needed to be, so I greatly simplified it in this PR.To test:
Before and after shots of two screens below: