Skip to content

Commit

Permalink
Use snake case for Events range params (#210)
Browse files Browse the repository at this point in the history
* Use snake case for Events range params
  • Loading branch information
amygdalama authored Jun 26, 2023
1 parent 205a75c commit 79901cd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/events/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ type ListEventsOpts struct {
After string `url:"after,omitempty"`

// Date range start for stream of Events.
RangeStart string `url:"rangeStart,omitempty"`
RangeStart string `url:"range_start,omitempty"`

// Date range end for stream of Events.
RangeEnd string `url:"rangeEnd,omitempty"`
RangeEnd string `url:"range_end,omitempty"`
}

// GetEventsResponse describes the response structure when requesting
Expand Down
2 changes: 1 addition & 1 deletion pkg/events/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestListEvents(t *testing.T) {
require.Equal(t, expectedResponse, events)
})

t.Run("ListEvents succeeds to fetch Events with a startRange and endRange", func(t *testing.T) {
t.Run("ListEvents succeeds to fetch Events with a range_start and range_end", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(ListEventsTestHandler))
defer server.Close()
client := &Client{
Expand Down

0 comments on commit 79901cd

Please sign in to comment.