Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ron: adding optional query params for PKCE flow #392

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

rarevalo13
Copy link
Contributor

Description

added query params to GetAuthorizationURLOpts struct and CodeVerifier to AuthenticateWithCodeOpts struct

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ x] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@rarevalo13 rarevalo13 requested a review from a team as a code owner January 27, 2025 21:03
@nicknisi
Copy link
Contributor

Changes make sense to me. Wondering if it needs test updates?

Also, it's marked as docs change required. Is there a PR for that?

@rarevalo13
Copy link
Contributor Author

@nicknisi added test, they pass locally, also the PR for the docs #392

@rarevalo13 rarevalo13 requested a review from mthadley February 6, 2025 22:05
@rarevalo13 rarevalo13 merged commit b018609 into main Feb 7, 2025
2 checks passed
@rarevalo13 rarevalo13 deleted the ron-addPKCEparams branch February 7, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants