-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectrum stopped working #3394
Comments
It's working to me, I cannot reproduce on my system. The issue should be elsewhere. As far as I know, that commit only added the delay compensation. And prior to that, there were other changes to improve the frequency update, which made useless the |
Could be caused by a library update but unsure exactly where to start when it comes to debugging. |
Please, post debugging messages as instructed here: https://github.com/wwmm/easyeffects/wiki/Reporting-bugs |
Here is the huge dump from |
As far as I could notice the logs are fine. @8BallBomBom run |
Here is the output after running pw-dot log
|
That is what it seems 🤔 How would I go about debugging a rendering issue? |
Try to change the settings. Maybe you set low points or a different style (dots rather than bars or lines). |
Doesn't seem to make any difference 😞 Here be how it is. |
Are you using the Flatpak version? If yes, try the one in Fedora repository. https://packages.fedoraproject.org/pkgs/easyeffects/easyeffects/ |
I'm using the absolute latest version compiled from source. Screen Recording is terrible but after installing from the Fedora repo directly everything seems to be working again. |
As far as I can see in your video the spectrum is working. Is the issue the update speed? |
Not at all, the recording was just to show that it is now working using the packaged version 😉 @wwmm @Digitalone1 Thanks for the help 😄 much appreciated. |
No, this seems to be an issue between |
This feels like a problem in the gtk4 library. And I do not say this just because I still can't reproduce the issue. Recently some users have had crashes related to gtk4's switch to the vulkan backend. It is totally possible something else is broken inside of it. And the vulkan backend crash is another one that does not happen on my hardware. Gtk4 is definitely having problems that only manifest themselves in specific setups. |
From a bisect between 7.1.8 and 7.1.9 it should be one of these commits.
|
If removing these commits solves the issue, it's better to revert and make it work for everyone. In the end this is not worth to fix since there will be a different implementation in Qt port, imho. |
It is basically the commits of #3340, so it might be up for a revert. |
Maybe related to missing package? Could be something like |
After running |
The Qt port will reuse the latency compensation code. What will be different is the code handling the spectrum drawing. @soupglasses which Linux Studio Plugins version do you have installed? The latency compensation code relies on the delay plugin. But now I remember that lsp releases older than |
Okay, I didn't give a deep look at the commit. I thought the delay code was implemented inside the spectrum, but I was wrong. The spectrum is just using the LSP delay plugin, so no LSP, no spectrum... |
From a quick look, its version |
To be fair this was considered in that long discussion about how to implement the compensation. But it was clearly going to be more complicated than just using the delay plugin we already use in EasyEffects. |
This version has the bug that was fixed in What the bug did was inserting silence in the plugin output instead of the processed audio. This totally explains your screenshot. |
Glad this got some more attention, wasn't exactly sure what was up, figured it was a library issue 🤔 |
So this was only happening for some distribution packages. On Flatpak the LSP dependency seems updated to |
This just happened to me: 2024-10-17T14:30:41-0500 DEBUG ---> Package easyeffects.x86_64 7.1.7-1.fc40 will be upgraded Downgrading easyeffects to 7.1.7-1 fixed the issue The LSP plugins version is: lsp-plugins-lv2-1.2.16-1.fc40.x86_64 Is it correct to assume that the LSP plugins RPM will need to be upgraded to 1.2.17 before I can upgrade easyeffects to 7.1.9-2 ? |
Seems you can just downgrade |
So you found 7.1.9-2 works with LSP plugins 1.12.15 ? For now I am on 7.1.7-1 and I put easyeffects in the exclude list in dnf.conf until the LSP plugins RPM gets updated. |
Either this or a downgrade to a LSP version that does not have the regression. |
Thanks for the info I will go ahead and upgrade easyeffects after downgrading LSP and put LSP in the exclude list instead |
EasyEffects Version
7.1.9
What package are you using?
Fedora
Distribution
Fedora 40 - KDE Spin
Describe the bug
After upgrading from version 7.1.8 up to 7.1.9 the Spectrum stopped working.
Seemed like this commit #3340 was responsible.
But now I'm not so sure as the issue occurred again with commits prior to that one 🫨
Expected Behaviour
Have the Spectrum rendering as audio plays through easyeffects.
Debug Log
Debug Log
Additional Information
Header/Library/Core Version: 1.0.7
Any additional information can be provided if needed.
Very unsure as to exactly what the issue is :/
The text was updated successfully, but these errors were encountered: