Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Dry/Wet Mix a̶n̶d̶ ̶D̶r̶y̶/̶W̶e̶t̶ ̶T̶i̶m̶e̶/̶S̶y̶n̶c̶ ̶O̶f̶f̶s̶e̶t̶ Sliders/Levels for the Convolver effect #3480

Open
mastr-ch13f opened this issue Nov 2, 2024 · 6 comments

Comments

@mastr-ch13f
Copy link

I would personally love to have these since there are pre-made impulse responses files that require having dry audio to be mixed along with the impulse-processed one (wet).

@violetmage
Copy link
Contributor

What would be the use for dry/wet sync/offset adjustment? I'm not very familiar with the more involved side of impulse response stuff, so just curious to understand the use case.

I agree that a dry/wet mix would probably be useful. It shouldn't be too hard to implement. I'll have a closer look later today or tomorrow.

@wwmm
Copy link
Owner

wwmm commented Nov 2, 2024

I think I had the intention of doing that and completely forgot about it.

@wwmm
Copy link
Owner

wwmm commented Nov 2, 2024

What would be the use for dry/wet sync/offset adjustment?

In most cases they allow the effect strength to be controlled. I do not know if something special happens when using them in a convolver.

@violetmage
Copy link
Contributor

I thought the dry/wet mix was the primary way to control effect "strength"?

I still don't really understand why dry/wet time offset would be needed.

@wwmm
Copy link
Owner

wwmm commented Nov 2, 2024

I still don't really understand why dry/wet time offset would be needed.

I am not sure. Usually time difference creates echo/reverberation. But that is what many impulse files already do. Maybe this would allow to fine tune the reverberation.

@mastr-ch13f
Copy link
Author

I make and use my own impulse response files for speaker/headphone equalization, in addition to (sometimes) adding pre-made IR file(s) in another Convolver for spatial effects to the audio output.

For example:
Dolby Headphone IRS.zip

Thinking about it now, the time/sync stuff might not be needed. But the dry/wet sliders are definitely needed on these types of IR files.

@mastr-ch13f mastr-ch13f changed the title [Request] Dry/Wet Mix and Dry/Wet Time/Sync Offset Sliders/Levels for the Convolver effect [Request] Dry/Wet Mix a̶n̶d̶ ̶D̶r̶y̶/̶W̶e̶t̶ ̶T̶i̶m̶e̶/̶S̶y̶n̶c̶ ̶O̶f̶f̶s̶e̶t̶ Sliders/Levels for the Convolver effect Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants