Auto Completion only on triggerChar

[felixendres]

Hi.
Thanks for the plugin, it's awesome!

I would like to configure completion such that it is only triggered automatically when I type a trigger character (e.g. ".", ">" for C++). If I need completions at other times, I can use C-X C-O.

I think this cannot be done with the current configuration options. I can get the behavior I want by modifying (or adding another) check for triggerKind after this line.

If you are fine with it, I'd like to contribute this as a PR:

• Create a new option "autoCompleteOnTriggerCharOnly" with a default of v:false
• Create a check after the linked line to return without completion if the above option is true but the trigger kind is something other than 2.
• Document the new option

Would you merge that? Is there anything else I need to consider?
Best regards.

[Shane-XB-Qian]

that part of code, which that func to get trigger kind maybe not complete correct, since now it not only kind 1 or 2, but also 3, so even you added such feat or flag, the result maybe weird still.

…

-- shane.xb.qian

[Shane-XB-Qian]

i meant you either refine that func (and related others code) to make it work fine with all kinds, or just disable auto-compl, then using omni-compl for all cases including trigger char cases.

[felixendres]

Ok, thank you for the feedback. I hope the PR addresses your concerns. Both options can now be set to any combination of trigger types and can be easily extended to include new ones.

[Shane-XB-Qian]

seems you are mis-understanding, i meant `trigger kind` was not only 1, 2 but also 3 now per spec. // if you cannot refine that, seems that PR was unnecessary.

…

-- shane.xb.qian

[felixendres]

Why do you mention trigger kind 3?
It doesn't exist in GetTriggerAttributes() on the master branch

What do you mean by "refine that"?

[Shane-XB-Qian]

Why do you mention trigger kind 3?

Because you mentioned in the OP: ``` get the behavior I want by modifying (or adding another) [check for triggerKind after this line](https://github.com/yegappan/lsp/blob/89d5350d756a9bd19bfc3ac0e30c53228e0b28d6/autoload/lsp/completion.vim#L478) ```

It doesn't exist [in GetTriggerAttributes()](https://github.com/yegappan/lsp/blob/master/autoload/lsp/completion.vim#L446-L466) on the master branch

it is in the spec. // fine, that's it.

…

-- shane.xb.qian