Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo on the Wiki page for Typescript/Javascript Language Server example #588

Open
ArenT1981 opened this issue Jan 21, 2025 · 4 comments

Comments

@ArenT1981
Copy link

Great plugin, is very fast with latest Vim.

The configuration example on the wiki page (https://github.com/yegappan/lsp/wiki) for Typescript/Javascript Language Server is missing the -- prefix for the stdio argument. It is also missing a comma on the initial name line. (The configuration is correct on the main README.md page). Took me some time to spot this as I was confused why the typescript server kept immediately exiting with error code 1 in my config!

Here is the corrected version with both the missing comma and the -- present for the stdio argument:

call LspAddServer([#{name: 'tsserver',
                 \   filetype: ['javascript', 'typescript'],
                 \   path: '/usr/local/bin/typescript-language-server',
                 \   args: ['--stdio']
                 \ }])
@ArenT1981
Copy link
Author

(Incidentally, one quick separate question: On a peek popup window, is there any way to horizontally scroll the popup? Vertical scrolling works fine.) zh and zl etc don't seem to do anything. Method signatures frequently disappear off the edge of the popup. Otherwise, is there a way to adjust the width/dimensions of the popup window, in practice it could be plenty wider than defaults for me even with vertical splits etc. lots of room on a 4K monitor.

@yegappan
Copy link
Owner

Great plugin, is very fast with latest Vim.

The configuration example on the wiki page (https://github.com/yegappan/lsp/wiki) for Typescript/Javascript Language Server is missing the -- prefix for the stdio argument. It is also missing a comma on the initial name line. (The configuration is correct on the main README.md page). Took me some time to spot this as I was confused why the typescript server kept immediately exiting with error code 1 in my config!

Thanks for reporting the issue. I have updated the wiki and correct the sample.

@yegappan
Copy link
Owner

(Incidentally, one quick separate question: On a peek popup window, is there any way to horizontally scroll the popup? Vertical scrolling works fine.) zh and zl etc don't seem to do anything. Method signatures frequently disappear off the edge of the popup. Otherwise, is there a way to adjust the width/dimensions of the popup window, in practice it could be plenty wider than defaults for me even with vertical splits etc. lots of room on a 4K monitor.

The zh and zl commands are not currently mapped to do the horizontal scrolling. Also, there is no configurable option to set the popup window width. I will modify the plugin to support horizontal scrolling (in a few weeks).

@ArenT1981
Copy link
Author

Thanks for the reply. Look forward to the horizontal scrolling patch when you have time in coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants