Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore completeItemsIsIncomplete and always filter items in omnifunc #590

Open
bennyyip opened this issue Jan 22, 2025 · 0 comments
Open

Comments

@bennyyip
Copy link
Contributor

According to this, rust-analyzer unconditionally set IsIncomplete to true for faster autocomplete response.
This results in omnicomplete always show a unfiltered list, which contains a lot of useless entries.
It should be OK always filter the list in omnifunc, because speed doesn't matter as much as in autocomplete. I can't see the necessity to not filter the list.

I suggest to remove the lspserver.completeItemsIsIncomplete check here:
https://github.com/yegappan/lsp/blob/main/autoload/lsp/completion.vim#L538
There is already a PR to remove the check(#568), but the author deleted the fork and closed the PR.
At least we should provide an option to bypass this check.

This should fix #366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant