Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rewriting of JSONs with syntax errors optional #90

Open
KrFreeFly opened this issue Aug 4, 2023 · 0 comments
Open

Make rewriting of JSONs with syntax errors optional #90

KrFreeFly opened this issue Aug 4, 2023 · 0 comments

Comments

@KrFreeFly
Copy link

KrFreeFly commented Aug 4, 2023

https://github.com/yeoman/configstore/blob/c70d76c19abe75920bdbb8c294b64f6bae68c15b/index.js#L46C49-L46C49

if (error.name === 'SyntaxError') {
				writeFileAtomic.sync(this._path, '', writeFileOptions);
				return {};
			}

Maybe add an option to leave .json with syntax errors untouched? We have large config files and sometimes lose them completely in case of error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant