dep!: replace os-name with systeminformation #84
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #83
PR Changes
os-name
systeminformation
Summary
What is your opinion on replacing the
os-name
dependency with something else that can also get the operating system name?This PR changes the dependency to
systeminformation
which can also get the name.The downside
The plus side
Testing
In terms of testing, I only ran the unit tests and it passes.
Final Thoughts
I believe it might be enough, but would like a review and if anyone can confirm that GA receives the data they expect.
If the bloating is an issue, maybe we could ask and see if they could extract it as a module so we could selectively pick what we want.
systeminformation
basically has similar information asos-name
and similar mapping asmacos-release
library thatos-name
uses. The plus side is it contains a fallback value to ensure that it will not crash with future releases of macOS.