cache problem , should condider the criteria

[yiqing-95]

getAllTags or getAllTagsWithModelsCount method when using cache should consider the criteria:

you see the code is like this

public function getAllTags($criteria = null) {
        if(!($tags = $this->cache->get('Taggable'.$this->getOwner()->tableName().'All'))){

            ...

            $this->cache->set('Taggable'.$this->getOwner()->tableName().'All', $tags);
        }

        return $tags;
    }

when the criteria is different method will return the same thing . may be it should like this (not sure)

public function getAllTags($criteria = null) {
                $extraCacheKey = empty($criteria) ? '' : serialize($criteria);  //  var_export($criteria,true); may consider too !

                if(!($tags = $this->cache->get('Taggable'.$this->getOwner()->tableName().'All'.$extraCacheKey ))){

            ...

            $this->cache->set('Taggable'.$this->getOwner()->tableName().'All'.$extraCacheKey, $tags);
        }

        return $tags;
    }

same problem with getAllTagsWithModelsCount method

[cebe]

You are right, cache must consider criteria.

[yiqing-95]

so do you have any solution to that ?
i just think about using CExpressionDependency , but not very sure whether there is a better solution ?

and not too clear about the cache expiration for using CExpressionDependency