forked from dollarshaveclub/stickybits
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useStickyClasses option adds classes early #49
Comments
Hey, thanks for filing an issue with Stickybits' first issue |
Hello. This problem is still actual, awaiting fix, thanks |
Experiencing the same issue. Is there any workaround method? Thanks. |
Have also run into this, haven't figured a workaround as yet |
Kilbourne
added a commit
to Kilbourne/stickybits
that referenced
this issue
Apr 28, 2022
Kilbourne
added a commit
to Kilbourne/stickybits
that referenced
this issue
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug
When using sticky classes, they are triggered on
.js-stickybit-parent
rather than the top of the activated element itself. If there are elements within.js-stickybit-parent
and above the activated element , the classes are added before the element becomes sticky. see the video link attached.Steps to reproduce the behavior:
useStickyClasses: true
.js-is-sticky
class is added when.js-stickybit-parent
hits the top of the viewport rather than when the element becomes sticky.Expected behavior
classes are added when the element becomes sticky
Bug Video
https://www.loom.com/share/9c6870eceaf147f29e5298945dae3f14
The text was updated successfully, but these errors were encountered: