-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling updates, allows not to set a new stickyBitStickyOffset value #78
Comments
We have the same problem... any ideas for solving? |
This seems to have done it for me: stickybitsInstance.update({ stickyBitStickyOffset: 20 });
stickybitsInstance.update(); |
So I've found an alternative way of updating it, by cleaning it up and it works for me:
Of course your cleaning up the old instance and making a new instance of it but for now it works for my use-case. |
I think the main problem is that update does not actually have an effect or move the element directly. It would need to call the |
Describe the bug
When calling
this.stickybitInstance.update({ stickyBitStickyOffset: <my-new-value> })
, the top spacing of the sticky element is not adjusted. It always seems to use the initial value, even though, the prop is updated on the instance.To Reproduce
Expected behavior
The sticky element uses the newly defined
stickyBitStickyOffset
as top value.Screenshots
Desktop (please complete the following information):
Additional context
Stickybits: 3.7.7
I think the following ticket on the old repository documents the same issue, even if I was not able to call the recalculation from outside myself: dollarshaveclub#663
The text was updated successfully, but these errors were encountered: