diff --git a/cluster/config-defaults.yaml b/cluster/config-defaults.yaml index 237326831e..74ea5f4507 100644 --- a/cluster/config-defaults.yaml +++ b/cluster/config-defaults.yaml @@ -44,9 +44,6 @@ karpenter_max_pods_per_node: "32" # legacy => 0.36.2-main-25.patched karpenter_version: "current" -# Configure whether to associate public ip when launching instances. -associate_public_ip_on_launch: "true" - # ALB config created by kube-aws-ingress-controller kube_aws_ingress_controller_ssl_policy: "ELBSecurityPolicy-TLS-1-2-2017-01" kube_aws_ingress_controller_idle_timeout: "1m" @@ -1157,8 +1154,14 @@ control_plane_load_balancer_internal: "none" # Optionally use internal subnets for running the nodes. This can be configured # a node pool level to only run a subset of nodes in the internal subnets. +# If this is true then `associate_public_ip_on_launch` is automatically treated +# as false. internal_node_subnets_enabled: "false" +# Configure whether to associate public ip when launching instances. +# This is only relevant when `internal_node_subnets_enabled` is false. +associate_public_ip_on_launch: "true" + # This allows setting custom sysctl settings. The config-item is intended to be # used on node-pools rather being set globally. # diff --git a/cluster/manifests/aws-cloud-controller-manager/daemonset.yaml b/cluster/manifests/aws-cloud-controller-manager/daemonset.yaml index 6a1a5f2008..bd1c6d4163 100644 --- a/cluster/manifests/aws-cloud-controller-manager/daemonset.yaml +++ b/cluster/manifests/aws-cloud-controller-manager/daemonset.yaml @@ -27,7 +27,7 @@ spec: - --cloud-provider=aws - --use-service-account-credentials=true - --configure-cloud-routes=false - image: container-registry.zalando.net/teapot/aws-cloud-controller-manager-internal:v1.31.4-master-136 + image: container-registry.zalando.net/teapot/aws-cloud-controller-manager-internal:v1.31.4-master-137 name: aws-cloud-controller-manager resources: requests: diff --git a/cluster/node-pools/master-default/stack.yaml b/cluster/node-pools/master-default/stack.yaml index d0004925eb..d19dbf9590 100644 --- a/cluster/node-pools/master-default/stack.yaml +++ b/cluster/node-pools/master-default/stack.yaml @@ -85,7 +85,7 @@ Resources: VolumeType: gp3 NetworkInterfaces: - DeviceIndex: 0 - # {{ if eq .NodePool.ConfigItems.associate_public_ip_on_launch "true" }} + # {{ if and (eq .NodePool.ConfigItems.associate_public_ip_on_launch "true") (ne .NodePool.ConfigItems.internal_node_subnets_enabled "true") }} AssociatePublicIpAddress: true # {{ end }} Groups: diff --git a/cluster/node-pools/master-default/userdata.yaml b/cluster/node-pools/master-default/userdata.yaml index 6d573d68ff..410276018a 100644 --- a/cluster/node-pools/master-default/userdata.yaml +++ b/cluster/node-pools/master-default/userdata.yaml @@ -206,7 +206,7 @@ write_files: limits: memory: {{ .Values.InstanceInfo.MemoryFraction (parseInt64 .Cluster.ConfigItems.apiserver_memory_limit_percent)}} {{- end }} - - image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/admission-controller:master-232 + - image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/admission-controller:master-234 name: admission-controller lifecycle: preStop: @@ -247,7 +247,7 @@ write_files: name: admission-controller-kubeconfig readOnly: true - name: skipper-admission-webhook - image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.240 + image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.252 args: - webhook - --address=:9085 @@ -424,7 +424,7 @@ write_files: value: {{ .Cluster.ConfigItems.apiserver_business_partner_ids }} {{ end }} - name: skipper-proxy - image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.240 + image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.252 args: - skipper - -access-log-strip-query @@ -475,7 +475,7 @@ write_files: name: ssl-certs-kubernetes readOnly: true - name: skipper-metrics - image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.240 + image: 926694233939.dkr.ecr.eu-central-1.amazonaws.com/production_namespace/teapot/skipper:v0.21.252 args: - skipper - -access-log-strip-query diff --git a/cluster/node-pools/worker-combined/stack.yaml b/cluster/node-pools/worker-combined/stack.yaml index a9653f094f..10b75248a0 100644 --- a/cluster/node-pools/worker-combined/stack.yaml +++ b/cluster/node-pools/worker-combined/stack.yaml @@ -154,7 +154,9 @@ Resources: VolumeType: gp3 NetworkInterfaces: - DeviceIndex: 0 + # {{ if and (eq .NodePool.ConfigItems.associate_public_ip_on_launch "true") (ne .NodePool.ConfigItems.internal_node_subnets_enabled "true") }} AssociatePublicIpAddress: true + # {{ end }} Groups: - !ImportValue '{{ .Cluster.ID }}:worker-security-group' EbsOptimized: false diff --git a/cluster/node-pools/worker-karpenter/provisioners.yaml b/cluster/node-pools/worker-karpenter/provisioners.yaml index f10b57e79e..d02f9acc9c 100644 --- a/cluster/node-pools/worker-karpenter/provisioners.yaml +++ b/cluster/node-pools/worker-karpenter/provisioners.yaml @@ -25,7 +25,7 @@ spec: securityGroupSelectorTerms: - tags: karpenter.sh/discovery: "{{ .Cluster.ID }}/WorkerNodeSecurityGroup" - # {{ if eq .NodePool.ConfigItems.associate_public_ip_on_launch "true" }} + # {{ if and (eq .NodePool.ConfigItems.associate_public_ip_on_launch "true") (ne .NodePool.ConfigItems.internal_node_subnets_enabled "true") }} associatePublicIPAddress: true # {{ end }} instanceProfile: "{{ .Cluster.ID | awsValidID }}-WorkerKarpenter-InstanceProfile" diff --git a/cluster/node-pools/worker-splitaz/stack.yaml b/cluster/node-pools/worker-splitaz/stack.yaml index b9a0f41c3b..975d0c79a3 100644 --- a/cluster/node-pools/worker-splitaz/stack.yaml +++ b/cluster/node-pools/worker-splitaz/stack.yaml @@ -159,7 +159,7 @@ Resources: VolumeType: gp3 NetworkInterfaces: - DeviceIndex: 0 - # {{ if eq .NodePool.ConfigItems.associate_public_ip_on_launch "true" }} + # {{ if and (eq .NodePool.ConfigItems.associate_public_ip_on_launch "true") (ne .NodePool.ConfigItems.internal_node_subnets_enabled "true") }} AssociatePublicIpAddress: true # {{ end }} Groups: