Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create local ci checks and github actions #78

Open
chrishalbert opened this issue Jan 16, 2024 · 3 comments
Open

Create local ci checks and github actions #78

chrishalbert opened this issue Jan 16, 2024 · 3 comments

Comments

@chrishalbert
Copy link
Contributor

While working #76, I had issues running all of the tests locally. Also, my PR didn't abide to go doc standards, which I also didn't catch. I think this repo could benefit from 2 things:

  1. Local CI Checks - This could be done using a Makefile, which would essentially be duplicating the checks locally so that a developer can verify their PR conforms to standards and the tests work. The Makefile could also automate the setup needed to run the tests locally.
  2. Github Actions - I think the free account allows like 2k action minutes p/month before getting charged. I'm not sure what the owner is ok with, but maybe there could be a post check upon a merge to master. This would keep the usage minimal, even though it would be nice to have this run for each PR - easier said though when I'm not floating the bill 😄
@szuecs
Copy link
Member

szuecs commented Jan 17, 2024

Yes thank you, I should create some gh action to lint and run tests.

@chrishalbert
Copy link
Contributor Author

Or even just a way that As a contributing developer, I can run tests and linting locally in the same manner that the CI checks run. On that note, how would I get a .chimp-token to get the zalando_test.go passing? Is there like a mocked server that I can point to for testing purposes? It seems like the CI checks run a number of services that require secrets which makes it hard to dev if not apart of the org.

@szuecs
Copy link
Member

szuecs commented Jan 23, 2024

@chrishalbert yes likely we should just skip the zalando_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants