Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some barcodes can't be checked with our library #48

Open
LilithWittmann opened this issue Jan 22, 2022 · 4 comments
Open

Some barcodes can't be checked with our library #48

LilithWittmann opened this issue Jan 22, 2022 · 4 comments

Comments

@LilithWittmann
Copy link
Member

LilithWittmann commented Jan 22, 2022

Screenshot 2022-01-22 at 16 05 26

Screenshot 2022-01-22 at 16 10 15

@BengtHagemeister
Copy link
Contributor

BengtHagemeister commented Jan 22, 2022

Hi,

I tried to reproduce this issue with the following outcome:

  • The first & third barcodes are standard EAN-13. They appear to be a bit deformed. But with the correct angle (it took a while) I did not have a problem reading them.
  • The second barcode is a GS1 Code 128. The library is able to scan this type of barcode but has apparently some problems when they are long (see Can't scan long GS1-128 -- title not entirely accurate ericblade/quagga2#390). But also with this one, after getting a good angle, I was able to read them.

To conclude, these might be just some bad prints on the packaging but not a general problem.

@cyberman54
Copy link

I can confirm that the barcode on side of package of "Hotgen" tests is scannable, but it takes a while / some trying.

@gidhap
Copy link

gidhap commented Jan 29, 2022

Same here, scanning works of Hotgen works but needs good lighting (sunlight works very good), contrast of black on lightbrown might be the issue.

@ericblade
Copy link

fwiw, the title on the linked issue isn't exactly the cause of the problem, more a bit of an issue with clarity. I strongly suspect there are some processing improvements that could be made either inside quagga, or outside and then pass the resulting image to quagga to decode, as well as finding that different settings can often make for a very large difference in the quality of results.

I'm glad to see another project that is making use of quagga2!

I have the unfortunate situation where my application reads almost exclusively UPC/EAN13 codes and the decoder for those seems to do very, very well. I can't speak for the quality of all of the others, only that most of the other readers are more susceptible to failure than the UPC reader.

I suspect there are major improvements that could be made, if anyone knows anything about image processing. It's unfortunately a topic that although I'm interested in, I haven't had any time to delve into. And I'm probably a lot better at just maintaining and improving in general, moreso than fixing processing issues. :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants