Remove duplicate plex names if multiple CMASs are present #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 39.91% 39.89% -0.03%
==========================================
Files 147 147
Lines 5003 5006 +3
Branches 873 872 -1
==========================================
Hits 1997 1997
- Misses 3006 3009 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew Twydell <[email protected]>
AndrewTwydell
force-pushed
the
plex-resource-primary-key
branch
from
edfad75 to
6f5530b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Current behaviour lists all CICSplexes returned from CMCI. If you have a multi-CMAS system, you can get multiple records with the same plex name with different cmas names. This results in duplicate plex entries.
This PR removes duplicates from the plex tree if multiple are returned.
Resolves #227
How to Test
Connect to a system with multiple cmas's and list the plexes, and don't see duplicates.
Review Checklist
I certify that I have:
Additional Comments