Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BotHandler to AbstractBotHandler. #690

Open
rht opened this issue May 18, 2021 · 1 comment
Open

Rename BotHandler to AbstractBotHandler. #690

rht opened this issue May 18, 2021 · 1 comment

Comments

@rht
Copy link
Contributor

rht commented May 18, 2021

To prevent confusion about its usage. To cement the fact that it is an abstract class used only for typing annotation purpose.
See discussion at https://chat.zulip.org/#narrow/stream/127-integrations/topic/deploying.20bots.20on.20heroku.3F.3F.3F.20--.20BotHandler.

Still need discussion: whether we should additionally use NotImplementedError instead of ... to proactively tell the library users if they accidentally use the class.

@timabbott
Copy link
Member

I think a naming change is likely sufficient to avoid library users accidentally using this class; we can always do something further after if we see the same confusion after a rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants