-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Windows CI from Appveyor to GitHub Actions #1070
Comments
@zulipbot claim |
Hello @ganpa3! Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
Much of the work is done in this PR: |
@ganpa3 that PR is for app installer. The test procedure on appveyor.yml is different. You can still work on it. |
Oh, actually, that PR includes |
Sounds like we should rebase/clean up #901, which seems to have been unfinished; I don't think the author has been active recently so someone else should take it up. |
@zulipbot claim |
Hello @ganpa3! Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
@zulipbot add "help wanted" |
@zulipbot claim |
Welcome to Zulip, @ganpa3! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@zulipbot ok |
This comment has been minimized.
This comment has been minimized.
@zulipbot claim |
Welcome to Zulip, @yaminijha1! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Fixes zulip#1070 In this commit I have added build workflow for windows in github action.
@zulipbot claim |
@zulipbot @timabbott I have created PR #1350 to fix this issue, Can you please review this PR? |
@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@priyank-p, can you please describe why this issue remains open? Initially, we had Appveyor for Windows, and then I defined a GitHub action for Windows in this PR #1350 If possible can you please review it? |
We'd want to have fewer CI platforms to keep track of.
See also https://chat.zulip.org/#narrow/stream/16-desktop/topic/appveyor.20ci.
The text was updated successfully, but these errors were encountered: