Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "stream" to "channel" in the UI #630

Closed
gnprice opened this issue Apr 24, 2024 · 2 comments · Fixed by #707
Closed

Rename "stream" to "channel" in the UI #630

gnprice opened this issue Apr 24, 2024 · 2 comments · Fixed by #707
Assignees
Labels
server-9 Things new in Zulip Server 9.0

Comments

@gnprice
Copy link
Member

gnprice commented Apr 24, 2024

This is the zulip-flutter counterpart of:

Unlike in zulip-mobile, in zulip-flutter let's do this unconditionally: we'll refer to a channel as a "channel" even on older servers where the web UI says "stream". By the time we roll out zulip-flutter to general users some months from now, it'll have been "channel" on Zulip Cloud and in the latest server release for at least a few months, so probably a relatively small fraction of users will be on older servers that use the old terminology, and it's OK if they see the new terminology in their mobile app.

(When we add wildcard mentions #234, those will need to condition on the server version, because it's a correctness issue: sending @**channel** to an older server just won't work. (I'll update #234 to note that.) But that's a lot more localized.)

This issue is purely about the user-facing strings: everywhere we say "stream" to the user, we should say "channel" instead. I'll file a follow-up issue for renaming identifiers in our codebase.

@gnprice gnprice added this to the Beta 2 milestone Apr 24, 2024
@gnprice gnprice added the server-9 Things new in Zulip Server 9.0 label Apr 24, 2024
@Khader-1
Copy link
Collaborator

Additionally, we have some strings that are not user-facing yet they're not identifiers (Test names / descriptions, comments etc) Some of them might become irrelevant when updating user-facing strings.

Should those be targeted in this issue? or should we target them in #631?

@gnprice
Copy link
Member Author

gnprice commented May 24, 2024

Good question. Let's have a PR for this issue that's focused purely on updating what the user sees — that will help keep down the complexity so we can finish and merge that PR quickly and include it in a release as soon as possible. (We make releases of this app every couple of weeks.)

Then for all kinds of updates that don't have any effect on the app's behavior, we do want to get those done (in order to have this migration complete and stop having two names to think about), but there isn't the same urgency because users don't see it, and in particular it doesn't matter at all whether those changes make it into a given release. So we'll handle those all as part of #631, and it's fine if that happens a week or two later.

@Khader-1 Khader-1 self-assigned this May 25, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue May 25, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue May 29, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue May 29, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue May 29, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jun 6, 2024
@gnprice gnprice closed this as completed in 187ecb0 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-9 Things new in Zulip Server 9.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants