Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override some Unicode emoji for display #944

Open
gnprice opened this issue Sep 16, 2024 · 0 comments
Open

Override some Unicode emoji for display #944

gnprice opened this issue Sep 16, 2024 · 0 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-design Visual and UX design
Milestone
Post-launch

Comments

@gnprice
Copy link
Member

gnprice commented Sep 16, 2024

We should probably port from zulip-mobile its "override" logic that applies to a handful of Unicode emoji:
https://github.com/zulip/zulip-mobile/blob/c979530d6804db33310ed7d14a4ac62017432944/src/emoji/codePointMap.js#L3-L33
https://github.com/zulip/zulip-mobile/blob/c979530d6804db33310ed7d14a4ac62017432944/src/emoji/data.js#L116

See comments there for motivation.

The first step will be to check that the un-overridden emoji actually do look wrong in zulip-flutter, as they did in zulip-mobile. A PR for this should include before/after screenshots that demonstrate the change.
@gnprice gnprice added a-content Parsing and rendering Zulip HTML content, notably message contents a-design Visual and UX design labels Sep 16, 2024
@gnprice gnprice added this to the Post-launch milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-design Visual and UX design
Projects
Flutter app
Status: No status
Milestone
Post-launch
Development

No branches or pull requests
1 participant
@gnprice