Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Follow web's change making dark mode's --color-text-default opaque #954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Sep 19, 2024

Fixes: #953

Before After
image image

…opaque

In zulip/zulip@8741c9e43, web changed --color-text-default from
`hsl(0deg 0% 100% / 75%)` to `hsl(0deg 0% 85%)`, to fix some bugs:
- literal Unicode emoji were not fully opaque
- strikethroughs appeared uneven; opacity was compounded where
  letters and strikethroughs overlapped.

The change also made message text a little bit higher contrast, and
that seems like an improvement. Discussion:
  https://chat.zulip.org/#narrow/stream/101-design/topic/Message.20text.20color.20in.20dark.20theme/near/1936707

To carry over this change, this commit updates
ContentTheme.textStylePlainParagraph, and also all our other colors
that were following web where the web counterpart was based on
--color-text-default. I believe that turns out to just be
MessageListTheme.messageTimestamp, added in beee77e; see that
commit message.

Before this, emoji in messages were not fully opaque in dark mode
(zulip#953), as Greg reported:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/dark.20theme/near/1924392
and that's fixed now.

Fixes: zulip#953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji in messages not fully opaque in dark mode
1 participant