-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No feedback shown when attempting to make a default stream private. #5286
Comments
Fingel
added a commit
to Fingel/zulip-mobile
that referenced
this issue
Mar 10, 2022
Displays a toast containing an error string if a call to updateExistingStream returns a failed promise. Fixes: zulip#5286
Fingel
added a commit
to Fingel/zulip-mobile
that referenced
this issue
Mar 10, 2022
Displays a toast containing an error string if a call to updateExistingStream returns a failed promise. Fixes: zulip#5286
Fingel
added a commit
to Fingel/zulip-mobile
that referenced
this issue
Mar 10, 2022
Displays a toast containing an error string if a call to updateExistingStream returns a failed promise. Fixes: zulip#5286
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
gnprice
changed the title
No feedback shown when attemping to make a default stream private.
No feedback shown when attempting to make a default stream private.
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Default streams (streams which new users are subscribed to by default) can not be made private. On web, when trying to change the permissions of a default stream to private, the following error is displayed:
Save failed: Default streams cannot be made private.
On mobile, the operation fails silently which may cause the user to believe they have changed the permissions of a stream when in fact they haven't.
When the request to set the default stream to private is sent, zulip server responds with this response:
I'm still getting familiar with how API errors are handled on mobile, but perhaps we should handle them here?
zulip-mobile/src/streams/streamsActions.js
Line 29 in 11cbbd1
Steps to reproduce:
Log in to a development Zulip server as an admin and try setting a default stream (#design, #devel, #social, #support, #Verona in the default dev environment) to private in the stream's settings. After saving go back into the stream settings and note that the setting has reverted, but there is no feedback detailing why.
Note: I got caught up by this when working on #5250 today, which is relevant in that it introduces the ability to save additional stream settings. It would be helpful to figure this out before fully implementing it.
The text was updated successfully, but these errors were encountered: