Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how muted streams are displayed on Streams screen #5514

Open
alya opened this issue Oct 5, 2022 · 12 comments · May be fixed by #5522
Open

Improve how muted streams are displayed on Streams screen #5514

alya opened this issue Oct 5, 2022 · 12 comments · May be fixed by #5522
Labels
good first issue help wanted

Comments

@alya
Copy link
Collaborator

alya commented Oct 5, 2022

In the subscribed streams UI, we should make the following changes to how muted streams are displayed:

  1. Show the stream's privacy icon, not a special "muted" icon. This will make it possible for the user to tell what the stream's privacy is, and we already convey the fact that the stream is muted with fading.
  2. Sort muted streams at the bottom of their section.

These changes will also make the mobile app UI more consistent with the left sidebar in the webapp.

CZO discussion
@Syed-Ansar
Copy link

Hey @alya @chrisbobbe I have proposed the solution in the CZO discussion. Please review once so that I can raise PR for it.

@Syed-Ansar Syed-Ansar linked a pull request Oct 8, 2022 that will close this issue
Open
@gnprice
Copy link
Member

gnprice commented Dec 1, 2022

See also #5425 which overlaps with this.

@TusharMinche

This comment was marked as outdated.

Sign in to view
@alya
Copy link
Collaborator Author

alya commented Jan 12, 2023 •
edited
Loading

@TusharMinche The next step on this issue is to address the feedback on #5522. Do you understand how to do that? If so, you could take over finishing that pull request, unless @Syed-Ansar is planning to pick it up again soon.

@MohdSaad

This comment was marked as off-topic.

Sign in to view
@gnprice

This comment was marked as off-topic.

Sign in to view
@rimaabdu

This comment was marked as outdated.

Sign in to view
@ashutosh887

This comment was marked as outdated.

Sign in to view
@chrisbobbe
Copy link
Contributor

@ashutosh887, thanks for your interest in contributing! Unfortunately, we don't expect to be able to review a pull request for this issue, since our effort is currently focused on https://github.com/zulip/zulip-flutter.

@ashutosh887

This comment was marked as off-topic.

Sign in to view
@samr874

This comment was marked as duplicate.

Sign in to view
@gnprice
Copy link
Member

gnprice commented Jun 3, 2024

@samr874 See above. If there were a change in the status since then, there'd have been an update here on the issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved how muted streams are displayed on Streams screen Syed-Ansar/zulip-mobile
9 participants
@gnprice @alya @chrisbobbe @MohdSaad @samr874 @ashutosh887 @Syed-Ansar @TusharMinche @rimaabdu