Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate narrow links using "channel" operator, not "stream", if server is recent #5861

Open
chrisbobbe opened this issue Apr 23, 2024 · 3 comments
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Apr 23, 2024

In zulip/zulip#28468, we plan to rename "stream" to "channel" in the Zulip UI.

When we generate narrow links, for example in quote-and-reply, we should start using the "channel" operator instead of the "stream" operator. But we should be careful only to do so if the server feature level is above a certain threshold where the new operator is officially supported. We should also wait until a release with #5860 has been out for several weeks.

Discussion: https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1786451

Related issues:

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 24, 2024
This refactor will help with zulip#5861, but Tim has reminded me that
we're not ready to address zulip#5861 until a release addressing zulip#5860
(as we did in the previous commit) has been out for a while:
  https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1786615
@gnprice gnprice added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Apr 25, 2024
@gnprice
Copy link
Member

gnprice commented Jul 8, 2024

We're leaving this out of Zulip Server 9, in order to give time for #5860 to reach a more complete subset of our users:
https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1848218

Instead it'll be in Server 10.

@chrisbobbe
Copy link
Contributor Author

chrisbobbe commented Jul 10, 2024

Should this get its "server release goal" label removed, then? Or we could keep it, with your message here tracking that it's for Server 10. Or maybe a "post-release" label or something instead?

@alya
Copy link
Collaborator

alya commented Jul 10, 2024

ETA on server: August 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Development

No branches or pull requests

3 participants