-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target Android 14 (set targetSdkVersion to 34), by 2023-10 deadline #5877
Comments
From that potentially-breaking changes article:
|
Quick manual testing on the office Android device (Android 9) showed no problems, which I guess isn't surprising because it's not Android 14. The app opened without crashing; notifications worked, with the app foregrounded/backgrounded/closed; and image uploads worked, both from the camera and the media library. (We don't support video uploads from the media library prior to Android 13, and we don't support video uploads from the camera on Android at all.) |
As we said on the last one of these, fc2dab7: This setting is not to be confused with the targetSdkVersion. The latter goes into the built manifest, and affects a wide range of behavior, so bumping it requires careful testing. This is used purely at build time, and should have no effect on runtime behavior. This value needs to be at least as high as targetSdkVersion, and we need to bump that to 34 soon (zulip#5877). So, do this to prepare for that. No build failures or warnings appeared for me with tools/test native --all-files .
As we said on the last one of these, fc2dab7: This setting is not to be confused with the targetSdkVersion. The latter goes into the built manifest, and affects a wide range of behavior, so bumping it requires careful testing. This is used purely at build time, and should have no effect on runtime behavior. This value needs to be at least as high as targetSdkVersion, and we need to bump that to 34 soon (zulip#5877). So, do this to prepare for that. No build failures or warnings appeared for me with tools/test native --all-files . Related: zulip#5877
Yeah — once |
Thanks for the detailed read through the breaking-changes page! I'll do a separate read too, for a cross-check. |
OK, doing my own read-through. After I read each of these items I'm also going and reading your notes on them — thanks for the thorough validation of where some of these APIs are used!
In short:
|
After our experience last year with the doc that's supposed to describe the effects of targetSdkVersion being deficient, I also read through the "Behavior changes: all apps" doc.
In short: I think there's nothing further to investigate from that doc. |
The deadline for this is now just over six weeks away (2024-10-31). The next steps are to try the upgrade and do some manual testing.
|
As we said on the last one of these, fc2dab7: This setting is not to be confused with the targetSdkVersion. The latter goes into the built manifest, and affects a wide range of behavior, so bumping it requires careful testing. This is used purely at build time, and should have no effect on runtime behavior. This value needs to be at least as high as targetSdkVersion, and we need to bump that to 34 soon (zulip#5877). So, do this to prepare for that. The build warnings change slightly, but the new warnings all seem acceptable. Details and discussion starting at: zulip#5879 (comment) Related: zulip#5877
This is the successor to #5453 (and an annual series of previous issues linked from there). We should update our
targetSdkVersion
to 34, meaning Android 14.The deadline
is earlier this year than in some previous years: it's 2024-08-31. (Much like last year, we can request an extension to 2024-11-01.)is 2024-10-31, after I requested an extension.The important steps for this upgrade are:
(edit: Also the changes not tied to targetSdkVersion, because for Android 13 last year a change that should have been in the first doc wasn't, and bit us, and the latter doc had an item that would have raised our suspicions if we'd read that doc closely.)
targetSdkVersion
.The text was updated successfully, but these errors were encountered: