Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common-background code to enable variants of themes (eg. gruvbox contrast settings) #1535

Open
neiljp opened this issue Jul 18, 2024 · 0 comments
Labels
area: colors/styles/themes enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jul 18, 2024

Description of suggested feature

Following #1415, it is easier to change the background color for a theme in a central location, and distinguish that color from where it is used for another purpose.

Other than updating this manually, this may help support the variations that some themes possess.

One good example of this may be gruvbox, where there are three contrast options, which possibly correspond to different background colors in each of the dark and light themes:
https://github.com/morhetz/gruvbox?tab=readme-ov-file#contrast-options
(also see the bg0 variants of colors above that)

Implementing this may be as simple as supporting a list of background values to select from, instead of only one, and would certainly be preferable to individual themes for each contrast setting.

@neiljp neiljp added enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org area: colors/styles/themes labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: colors/styles/themes enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org
Projects
None yet
Development

No branches or pull requests

1 participant