Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current terminal window size to About popup #1536

Open
neiljp opened this issue Jul 18, 2024 · 5 comments · May be fixed by #1542
Open

Add current terminal window size to About popup #1536

neiljp opened this issue Jul 18, 2024 · 5 comments · May be fixed by #1542
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jul 18, 2024

Description of suggested feature

It would be useful during reporting issues to know the size of the current terminal.

This is already available at runtime via urwid, since the popup code relies on it to determine which width (and maximum width) to use.

This entry should appear at the bottom of the 'Detected Environment' section of the 'About' popup.

Since the terminal size can often be changed while a popup is open, we will likely want to call this 'Current terminal size', though this can be adjusted later during a PR or after merging.

@neiljp neiljp added enhancement New feature or request help wanted This issue should be clear enough to work on good first issue Good for newcomers labels Jul 18, 2024
@Swarnim114
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @Swarnim114! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@Swarnim114
Copy link
Collaborator

@neiljp
image

this is the desired result right ?

@neiljp
Copy link
Collaborator Author

neiljp commented Jul 25, 2024

@Swarnim114 I replied in the PR 👍

@Swarnim114
Copy link
Collaborator

@neiljp please check the pr again

Swarnim114 added a commit to Swarnim114/zulip-terminal that referenced this issue Aug 3, 2024
Swarnim114 added a commit to Swarnim114/zulip-terminal that referenced this issue Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Projects
None yet
3 participants