Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash for user with no subscriptions (eg. new bot) #895

Open
neiljp opened this issue Jan 28, 2021 · 4 comments · May be fixed by #1543
Open

Crash for user with no subscriptions (eg. new bot) #895

neiljp opened this issue Jan 28, 2021 · 4 comments · May be fixed by #1543
Labels
bug: crash
Milestone
Next Release

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jan 28, 2021

Currently producing a fresh bot and using the zuliprc in ZT causes a crash, unless some streams are pre-subscribed for it.

This shouldn't be an issue for regular uses, who tend to get subscriptions automatically, but it's possible that a user could lose their subscriptions, so we should avoid this issue in any case.
@neiljp neiljp added this to the Release after next milestone Jan 28, 2021
@avats-dev
Copy link
Collaborator

@neiljp can you guide me a bit to resolve this? I would like to contribute.

@neiljp
Copy link
Collaborator Author

neiljp commented Feb 18, 2021

I would suggest ensuring you can duplicate this first, which likely should be achievable by creating a bot user and running zulip-term with the matching zuliprc file. I'm guessing the UI code is not resilient to an empty list of streams, but I've not tried reproducing this bug myself recently - you should get a traceback indicating where the error is to some degree.

@avats-dev
Copy link
Collaborator

ok, thanks. I will try that and update.

@Abhirup-99
Copy link
Contributor

@avats-dev are you still working on this? I would like to take a stab at it.

This was referenced Aug 7, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: crash
Projects
None yet
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Handling Empty Narrows Niloth-p/zulip-terminal
3 participants
@neiljp @avats-dev @Abhirup-99