-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Replace most sticky regexs with pure parser combinators #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 50a7d5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Feb 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was a little bored and distracting myself from another parsing-related task, which made me curious whether recent V8 changes make this change worthwhile — and it does seem pretty impactful.
This removes most sticky regexes for manual character peeks, and attempts to be as efficient as possible in only checking an upcoming character once, if possible. The exceptions here are:
null | true | false
an enum value may follow)on
in inline fragmentsIn a few select sections we're still checking a character twice, but this seems to be the minimal amount of operations.
The benchmarks above are run only with
parser.bench.ts
active, since running multiple benchmarks in one Vitest run skews the results. It'd still show this branch as faster by approximately the same percentage, but the result is less stable.graphql
benchmarks we arrive at:~157,000op/s -> ~210,000ops/s (+/- 5,000)
Bundle size impact (after a few manual tweaks) is positive and a reduction overall, but essentially identical with a full Terser run anyway.
Set of changes
valueRe
with a large switch statement that checks the first character manuallyStringValue
nodes without a regex (since they're really simple)intRe
with a manual digit parser (since first char-
is known, this is trivial)floatPartRe
regex in an if-statement check since prior char is already loadednameRe
with manual parsingname()
parserSource | string
check'{'
checks for selection sets into separate function (doesn't impact perf)