-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/94 and more #105
base: master
Are you sure you want to change the base?
Issue/94 and more #105
Conversation
added short notice directing users to go to af-vcd instead.
moved to function, made xh const to encapsulate it within that function, outside of window scope.
Fixed issue with link to new site (forgot a quotation mark haha). Also made the out-of-date disclaimer larger.
2. Uses word boundaries to only highlight complete words when highlighting duplicates 3. Does not highlight stop words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the abbreviations that is being proposed doesn't make sense for a few reasons:
-
The abbreviations list is case sensitive, and I don't think people would actually go out and type AIR FORCE SMART OPERATIONS FOR THE 21ST CENTURY in all caps. However if we added an option to make abbreviations case insensitive, this would be more useful. Would also need to handle the option/edge case where people don't like the first word of the bullet abbreviated.
-
The same is true for even some of the shorter ones, like "Senior Master Sergeant," it is going to cause more effort than it's worth to type that out just to have the benefit of standard abbreviations. I think it might be more beneficial to think of this as like autocorrect and include entries like smgt or senior msgt that get abbreviated to SMsgt
Addresses #94.
Also doesn't highlight stop words.
Also only highlights whole words.