update demo data to new kath data; closes #24 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will take a look asap. |
|
I still can't reproduce that. Grrr ... now properly officially annoying that you keep getting an error that i am unable to reproduce ... not sure what to do |
|
Bizarre. Could it be related to the mapbox api keys? I think that's unlikely... here's my session info in any case: devtools::install_github("mpadge/upthat", "new-demo-data")
#> Skipping install of 'upthat' from a github remote, the SHA1 (a0c48059) has not changed since last install.
#> Use `force = TRUE` to force installation
upthat::runUpthat()
#> Loading required package: shiny
#>
#> Listening on http://127.0.0.1:4922
#> Reading this matching file: /home/robin/R/x86_64-pc-linux-gnu-library/3.6/upthat/net.Rds
#> Warning: Error in if: argument is of length zero
#> Warning: Error in if: argument is of length zeroCreated on 2019-12-23 by the reprex package (v0.3.0) devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#> setting value
#> version R version 3.6.2 (2019-12-12)
#> os Ubuntu 18.04.3 LTS
#> system x86_64, linux-gnu
#> ui X11
#> language en_GB:en
#> collate en_GB.UTF-8
#> ctype en_GB.UTF-8
#> tz Europe/London
#> date 2019-12-23
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#> package * version date lib source
#> assertthat 0.2.1 2019-03-21 [3] CRAN (R 3.5.3)
#> backports 1.1.5 2019-10-02 [3] CRAN (R 3.6.1)
#> callr 3.4.0 2019-12-09 [3] CRAN (R 3.6.2)
#> cli 2.0.0 2019-12-09 [3] CRAN (R 3.6.2)
#> colorspace 1.4-1 2019-03-18 [3] CRAN (R 3.5.3)
#> colourvalues 0.3.1 2019-11-15 [1] CRAN (R 3.6.1)
#> crayon 1.3.4 2017-09-16 [3] CRAN (R 3.5.0)
#> crosstalk 1.0.0 2016-12-21 [3] CRAN (R 3.5.0)
#> curl 4.3 2019-12-02 [1] CRAN (R 3.6.1)
#> desc 1.2.0 2018-05-01 [3] CRAN (R 3.5.0)
#> devtools 2.2.1 2019-09-24 [3] CRAN (R 3.6.1)
#> digest 0.6.23 2019-11-23 [3] CRAN (R 3.6.1)
#> dplyr 0.8.3 2019-07-04 [3] CRAN (R 3.6.1)
#> ellipsis 0.3.0 2019-09-20 [2] CRAN (R 3.6.1)
#> evaluate 0.14 2019-05-28 [3] CRAN (R 3.6.0)
#> fansi 0.4.0 2018-10-05 [3] CRAN (R 3.5.1)
#> fastmap 1.0.1 2019-10-08 [3] CRAN (R 3.6.1)
#> fs 1.3.1 2019-05-06 [3] CRAN (R 3.6.0)
#> ggplot2 3.2.1 2019-08-10 [3] CRAN (R 3.6.1)
#> glue 1.3.1 2019-03-12 [3] CRAN (R 3.5.3)
#> gtable 0.3.0 2019-03-25 [3] CRAN (R 3.5.3)
#> highr 0.8 2019-03-20 [3] CRAN (R 3.5.3)
#> htmltools 0.4.0 2019-10-04 [3] CRAN (R 3.6.1)
#> htmlwidgets 1.5.1 2019-10-08 [3] CRAN (R 3.6.1)
#> httpuv 1.5.2 2019-09-11 [3] CRAN (R 3.6.1)
#> httr 1.4.1 2019-08-05 [3] CRAN (R 3.6.1)
#> jsonlite 1.6 2018-12-07 [3] CRAN (R 3.5.1)
#> knitr 1.26 2019-11-12 [3] CRAN (R 3.6.1)
#> later 1.0.0 2019-10-04 [3] CRAN (R 3.6.1)
#> lazyeval 0.2.2 2019-03-15 [3] CRAN (R 3.5.3)
#> leaflet 2.0.3 2019-11-16 [3] CRAN (R 3.6.1)
#> lifecycle 0.1.0 2019-08-01 [3] CRAN (R 3.6.1)
#> magrittr 1.5 2014-11-22 [3] CRAN (R 3.5.0)
#> mapdeck 0.2.1007 2019-12-23 [1] Github (SymbolixAU/mapdeck@2f080f8)
#> memoise 1.1.0 2017-04-21 [3] CRAN (R 3.5.0)
#> mime 0.8 2019-12-19 [1] CRAN (R 3.6.2)
#> munsell 0.5.0 2018-06-12 [3] CRAN (R 3.5.0)
#> pillar 1.4.3 2019-12-20 [1] CRAN (R 3.6.2)
#> pkgbuild 1.0.6 2019-10-09 [3] CRAN (R 3.6.1)
#> pkgconfig 2.0.3 2019-09-22 [3] CRAN (R 3.6.1)
#> pkgload 1.0.2 2018-10-29 [3] CRAN (R 3.5.1)
#> prettyunits 1.0.2 2015-07-13 [3] CRAN (R 3.5.0)
#> processx 3.4.1 2019-07-18 [3] CRAN (R 3.6.1)
#> promises 1.1.0 2019-10-04 [3] CRAN (R 3.6.1)
#> ps 1.3.0 2018-12-21 [3] CRAN (R 3.5.2)
#> purrr 0.3.3 2019-10-18 [3] CRAN (R 3.6.1)
#> R6 2.4.1 2019-11-12 [3] CRAN (R 3.6.1)
#> Rcpp 1.0.3 2019-11-08 [3] CRAN (R 3.6.1)
#> remotes 2.1.0 2019-06-24 [1] CRAN (R 3.6.0)
#> rlang 0.4.2 2019-11-23 [3] CRAN (R 3.6.1)
#> rmarkdown 2.0 2019-12-12 [1] CRAN (R 3.6.1)
#> rprojroot 1.3-2 2018-01-03 [1] CRAN (R 3.6.0)
#> scales 1.1.0 2019-11-18 [3] CRAN (R 3.6.1)
#> sessioninfo 1.1.1 2018-11-05 [3] CRAN (R 3.5.1)
#> shiny * 1.4.0 2019-10-10 [3] CRAN (R 3.6.1)
#> stringi 1.4.3 2019-03-12 [3] CRAN (R 3.5.3)
#> stringr 1.4.0 2019-02-10 [3] CRAN (R 3.5.2)
#> testthat 2.3.1 2019-12-01 [1] CRAN (R 3.6.1)
#> tibble 2.1.3 2019-06-06 [1] CRAN (R 3.6.0)
#> tidyselect 0.2.5 2018-10-11 [3] CRAN (R 3.5.1)
#> upthat 0.1.0 2019-12-23 [1] Github (mpadge/upthat@a0c4805)
#> usethis 1.5.1 2019-07-04 [3] CRAN (R 3.6.1)
#> webshot 0.5.2 2019-11-22 [3] CRAN (R 3.6.1)
#> withr 2.1.2 2018-03-15 [3] CRAN (R 3.5.0)
#> xfun 0.11 2019-11-12 [1] CRAN (R 3.6.1)
#> xml2 1.2.2 2019-08-09 [3] CRAN (R 3.6.1)
#> xtable 1.8-4 2019-04-21 [1] CRAN (R 3.6.0)
#> yaml 2.2.0 2018-07-25 [3] CRAN (R 3.5.1)
#>
#> [1] /home/robin/R/x86_64-pc-linux-gnu-library/3.6
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library |
|
One thought: have you tried with the latest version of mapdeck? |
|
Yeah, my mapdeck is current dev. An error like that seems suspiciously likely to be our fault, but I can't figure out where because I can't reproduce it. Have you tried in a fresh docker? I couldn't repro it that way, so if you can then we'd at least be getting somewhere |
|
Will give it a go now, good shout. |
|
Currently compiling all the C++ code needed for the latest version of mapdeck on the rocker/geospatial image. Which docker image did you try it on @mpadge out of interest? |
|
Can reproduce on laptop and desktop, now just waiting to test on latest rocker/geospatial image... |
|
I tried it on |
|
As per opening and commenting on #54 I'm still getting the bug. But this PR is not relevant to it. Happy to merge but think we should prioritise that. I suspect it's the lack of crash data but not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Robinlovelace This should rectify #24, but let me know what you think before merging.