-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type description improvements #2176
Open
niklasharrysson
wants to merge
43
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
niklasharrysson:typedesc_updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Type description improvements #2176
niklasharrysson
wants to merge
43
commits into
AcademySoftwareFoundation:main
from
niklasharrysson:typedesc_updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes and replaces #2107, which can be closed if this PR is approved. |
source/JsMaterialX/JsMaterialXGenGlsl/JsGlslShaderGenerator.cpp
Outdated
Show resolved
Hide resolved
niklasharrysson
commented
Jan 27, 2025
source/JsMaterialX/JsMaterialXGenEssl/JsEsslShaderGenerator.cpp
Outdated
Show resolved
Hide resolved
ld-kerley
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me - thanks for getting this all squared away!
I left a small question below - but happy to defer to whatever you think.
Signed-off-by: Jonathan Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list is an overhaul of the type system in shader generation.
Improvements include:
Co-work with @ld-kerley