Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MDL 1.10 #2214

Merged

Conversation

krohmerNV
Copy link
Contributor

Update the MDL code generator to make use of MDL 1.10 features that. This includes:

  • taking the color82 of the generalized Schlick BSDF into account
  • implement the Zeltner mode for the Sheen BSDF
  • add energy conservation to the Oren-Nayar diffuse BSDF

krohmerNV added a commit to krohmerNV/MaterialX that referenced this pull request Feb 12, 2025
krohmerNV added a commit to krohmerNV/MaterialX that referenced this pull request Feb 12, 2025
@jstone-lucasfilm jstone-lucasfilm changed the title MDL: update to use MDL 1.10 implementations Add support for MDL 1.10 Feb 13, 2025
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @krohmerNV!

@jstone-lucasfilm jstone-lucasfilm merged commit 7fc041d into AcademySoftwareFoundation:main Feb 13, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants