[AAE-15727] add and modify columns for name in project table #1178
Conversation
replacing name for Projects
for projects
|
|
|
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
Edit - changed review on @LorenzoDiGiuseppe comment, I think it has a good point.
| public void setName(String name) { | ||
| this.name = name; | ||
| setTechnicalName(name); | ||
|
|
||
| //TODO: Modify temporary code that sets display name same as technical name | ||
| setDisplayName(name); | ||
| } |
There was a problem hiding this comment.
I will leave just a comment since I will be off after today and I don't want to block the PR.
I think we should not set both names here, but just delegate to setTechnicalName. If it is required to set also the display name, I think it would be better doing it in another place to avoid having issues when get/set name will be deleted.
In addition, it would be easier implementing getName and setName with a default implementation in the interfaces to avoid repeating the same behavior.
| @@ -50,7 +50,7 @@ public static ModelingNamingIdentifier<Project> projectNamed(String name) { | |||
| return new ModelingNamingIdentifier<Project>(name) { | |||
| @Override | |||
| protected String getName(Project project) { | |||
| return project.getName(); | |||
| return project.getTechnicalName(); | |||
There was a problem hiding this comment.
The step to renaming the getTechnicalName that is not the final name yet should be done in the end Why it's already here?
No description provided.