Asserting how silence maps in the hash domain.

AddictedCS · Jun 14, 2024 · e6cc3e8 · e6cc3e8
1 parent e9fe63c
commit e6cc3e8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/SoundFingerprinting.Tests/Unit/Math/SimilarityUtilityTest.cs b/src/SoundFingerprinting.Tests/Unit/Math/SimilarityUtilityTest.cs
@@ -65,6 +65,16 @@ public void CalculateJaccardSimilarityCorrect()
             Assert.AreEqual(5f / 6, result, 0.0001);
         }
 
+        [Test]
+        public void SilenceShouldMapToNegativeOne()
+        {
+            byte[] minHashes = [255, 255, 255, 255];
+            int[] hashes = hashConverter.ToInts(minHashes, 1);
+
+            Assert.AreEqual(1, hashes.Length);
+            Assert.AreEqual(-1, hashes[0]);
+        }
+
         private byte[] GenerateByteArray(int length)
         {
             var ran = new Random();

diff --git a/src/SoundFingerprinting/Data/AVHashes.cs b/src/SoundFingerprinting/Data/AVHashes.cs
@@ -135,7 +135,7 @@ public AVHashes WithStreamId(string streamId)
         }
 
         /// <summary>
-        ///  Add an additional property to the Audio/Video hashes object.
+        ///  Add a property to the Audio/Video hashes object.
         /// </summary>
         /// <param name="key">Property key.</param>
         /// <param name="value">Property value.</param>

diff --git a/src/SoundFingerprinting/FingerprintService.cs b/src/SoundFingerprinting/FingerprintService.cs
@@ -86,7 +86,7 @@ internal IEnumerable<Fingerprint> CreateOriginalFingerprintsFromFrames(IEnumerab
             var images = normalized.ToList();
             if (!images.Any())
             {
-                return Enumerable.Empty<Fingerprint>();
+                return [];
             }
 
             var fingerprints = new ConcurrentBag<Fingerprint>();