(docs): Remove makeLocalAccount #1208
Open
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying documentation with
|
| Latest commit: |
7d38f69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2f4a53e1.documentation-7tp.pages.dev |
| Branch Preview URL: | https://ivan-10106-remove-makelocala.documentation-7tp.pages.dev |
|
Cloudflare deployment logs are available here |
turadg
reviewed
Sep 18, 2024
| @@ -16,14 +16,6 @@ Retrieves the chain information and provides access to chain-specific methods. S | |||
| const chain = await orchestrator.getChain('chainName') | |||
| ``` | |||
|
|
|||
| ### makeLocalAccount | |||
There was a problem hiding this comment.
This is accurate but I suspect not complete. If this repo is about a guide to using the API, shouldn't we also indicate how to make a local account? (getChain('agoric')
If this is just a presentation of the API, why is it defined manually here? We can generate API docs from the API repo.
0xpatrickdev
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Agoric/agoric-sdk#10106 the method
orchestrator.makeLocalAccountwill be removed.This PR removes docs about that method. There are no other instances of this method in the docs repo.