fix: match os_uname().sysname, not version #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
:lua vim.print(vim.loop.os_uname())
output:If we try
is_unix = vim.loop.os_uname().version:match("Linux")
, it would befalse
, which is incorrect, so this PR usesvim.loop.os_uname().sysname:match("Linux")
instead.Before:
I searched the code base and found this:
Fixes (no issues were found)
Type of change
How Has This Been Tested?
After the change, it would correctly goes into the 3 os branch.
But under wayland,
vim.fn.system { "wl-copy", "<", filename }
would copy literal string:< [filename].png
. I'll open another PR.Configuration:
nvim --version
):I don't know if this behavior is related to neovim version, anyway I use nightly build.
$ uname -a Linux arc 6.10.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 19 Aug 2024 17:02:39 +0000 x86_64 GNU/Linux
Arch Linux x86_64, kernel linux-zen, kitty 0.36.1, Hyprland (wayland)
Checklist
rather simple change, so no comment :)
no documentation change is needed
and I agree to follow it.