Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer gem as a dependency #200

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

AaronRustad
Copy link
Contributor

There is a warning when starting up retest that the observer gem will be removed in Ruby 3.4. This PR adds the dependency in.

/Users/xxx/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/retest-1.13.0/lib/retest.rb:4: warning: observer was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add observer to your Gemfile or gemspec. Also contact author of retest-1.13.0 to add observer into its gemspec.

@AaronRustad AaronRustad changed the title Ar/add observer dependency Add observer gem as a dependency Mar 5, 2024
@AlexB52
Copy link
Owner

AlexB52 commented Mar 5, 2024

Thanks @AaronRustad, the change looks good.
I'll make a quick research on how this impacts previous ruby version from 2.5+ before we merge the change.
That said, it might all be fine.

@AaronRustad AaronRustad force-pushed the ar/add-observer-dependency branch from 666ba8f to 0b6f9cf Compare March 11, 2024 15:28
@AlexB52 AlexB52 merged commit 3725480 into AlexB52:main Mar 11, 2024
14 checks passed
@AlexB52
Copy link
Owner

AlexB52 commented Mar 11, 2024

Thank you @AaronRustad, it's been merged and released in 1.13.1
https://rubygems.org/gems/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants