Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL Analysis: replace SFINAE with overloaded restricted templates #13947

Merged
merged 7 commits into from
Feb 20, 2025
Merged

DPL Analysis: replace SFINAE with overloaded restricted templates #13947

merged 7 commits into from
Feb 20, 2025
+617 −629

Conversation

aalkin
Copy link
Member

@aalkin aalkin commented Feb 7, 2025 •
edited
Loading

Replaces analysis manager structs with restricted templates. This should improve compilation time of adaptAnalysisTask.

@aalkin aalkin requested a review from a team as a code owner February 7, 2025 10:10
@aalkin aalkin requested a review from ktf February 7, 2025 10:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild alibuild mentioned this pull request Feb 7, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Feb 7, 2025

Error while checking build/O2/fullCI_slc9 for d3762a4 at 2025-02-07 11:36:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:8: error: 'OutputManager' is not a class template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:44: error: explicit specialization of non-template 'o2::framework::OutputManager'
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:8: error: 'OptionManager' is not a class template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:44: error: explicit specialization of non-template 'o2::framework::OptionManager'
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:51: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:46: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:8: error: 'OutputManager' is not a class template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:44: error: explicit specialization of non-template 'o2::framework::OutputManager'
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:8: error: 'OptionManager' is not a class template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:44: error: explicit specialization of non-template 'o2::framework::OptionManager'
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:51: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc9_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:46: error: qualified-id in declaration before '(' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Feb 7, 2025

Error while checking build/O2/fullCI for d3762a4 at 2025-02-07 12:33:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:8: error: 'OutputManager' is not a class template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:44: error: explicit specialization of non-template 'o2::framework::OutputManager'
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:8: error: 'OptionManager' is not a class template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:44: error: explicit specialization of non-template 'o2::framework::OptionManager'
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:51: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:46: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:8: error: 'OutputManager' is not a class template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:626:44: error: explicit specialization of non-template 'o2::framework::OutputManager'
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:8: error: 'OptionManager' is not a class template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:661:44: error: explicit specialization of non-template 'o2::framework::OptionManager'
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:669:51: error: qualified-id in declaration before '(' token
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:5: error: 'o2::framework::OptionManager' is not a template
/sw/SOURCES/O2/13947-slc8_x86-64/0/Generators/include/Generators/AODToHepMC.h:676:46: error: qualified-id in declaration before '(' token
ninja: build stopped: subcommand failed.

Full log here.

@aalkin aalkin mentioned this pull request Feb 10, 2025
Merged
@aalkin aalkin force-pushed the refactor-analysis-managers branch from d3762a4 to f919b12 Compare February 13, 2025 12:04
@aalkin aalkin force-pushed the refactor-analysis-managers branch from ca45495 to 5e06f1d Compare February 19, 2025 11:28
ktf
ktf approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on hyperloop as well.

@ktf ktf enabled auto-merge (squash) February 20, 2025 15:40
@ktf ktf merged commit 4717d6b into AliceO2Group:dev Feb 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktf ktf ktf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalkin @alibuild @ktf