Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUON: added option for storing nCandidates in the MFT-MCH matching #13977

Merged
merged 1 commit into from
Feb 20, 2025
Merged

MUON: added option for storing nCandidates in the MFT-MCH matching #13977

merged 1 commit into from
Feb 20, 2025
+1 −0

Conversation

aferrero2707
Copy link
Collaborator

@aferrero2707 aferrero2707 commented Feb 18, 2025 •
edited
Loading

The new option also requires the changes in AliceO2Group/O2DPG#1910 in order to be enabled.

@aferrero2707 aferrero2707 requested a review from a team as a code owner February 18, 2025 10:23
@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aferrero2707 aferrero2707 mentioned this pull request Feb 18, 2025
Merged
@aferrero2707
Copy link
Collaborator Author

@mcoquet642 could you please have a look? Thanks!

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for eb2a8d9 at 2025-02-20 04:26:

[4996/5696] Generating G__O2TPCCalibration.cxx, ../../../stage/lib64/G__O2TPCCalibration_rdict.pcm, ../../../stage/lib64/libO2TPCCalibration.rootmap
[4997/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPulserParam.cxx.o
[4998/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/DigitDumpParam.cxx.o
[4999/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPedestalParam.cxx.o
[5000/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCGroupHelperSector.cxx.o
[5001/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCAverageGroupHelper.cxx.o
[5002/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCFourierTransformBase.cxx.o
[5003/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/RobustAverage.cxx.o
[5004/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCAverageGroupBase.cxx.o
[5005/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCGroupHelperRegion.cxx.o
[5006/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCGroup.cxx.o
[5007/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/SACParameter.cxx.o
[5008/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCDrawHelper.cxx.o
[5009/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibLaserTracks.cxx.o
[5010/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/SACDecoder.cxx.o
[5011/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCFourierTransform.cxx.o
[5012/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibRawBase.cxx.o
[5013/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/TrackDump.cxx.o
[5014/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/DigitDump.cxx.o
[5015/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2test-calibration-IDCFourierTransform.dir/__/__/__/Common/Utils/src/fpu.cxx.o
[5016/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CorrMapParam.cxx.o
[5017/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/SACDrawHelper.cxx.o
[5018/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2test-tpc-IDCAverageGroup.dir/__/__/__/Common/Utils/src/fpu.cxx.o
[5019/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/DigitAdd.cxx.o
[5020/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/TPCScaler.cxx.o
[5021/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCGroupingParameter.cxx.o
[5022/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/TPCMShapeCorrection.cxx.o
[5023/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibTreeDump.cxx.o
[5024/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/SACFactorization.cxx.o
[5025/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/SACCCDBHelper.cxx.o
[5026/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPadGainTracks.cxx.o
[5027/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPulser.cxx.o
[5028/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPedestal.cxx.o
[5029/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCAverageGroup.cxx.o
[5030/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibPadGainTracksBase.cxx.o
[5031/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CorrectdEdxDistortions.cxx.o
[5032/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/LaserTracksCalibrator.cxx.o
[5033/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2test-calibration-IDCFourierTransform.dir/test/testO2TPCIDCFourierTransform.cxx.o
[5034/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/TPCFastSpaceChargeCorrectionHelper.cxx.o
[5035/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2test-tpc-IDCAverageGroup.dir/test/testO2TPCIDCAverageGroup.cxx.o
[5036/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibratordEdx.cxx.o
[5037/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/VDriftHelper.cxx.o
[5038/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCCCDBHelper.cxx.o
[5039/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/IDCFactorization.cxx.o
[5040/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/TPCVDriftTglCalibration.cxx.o
[5041/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibdEdx.cxx.o
[5042/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalibratorPadGainTracks.cxx.o
[5043/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CorrectionMapsLoader.cxx.o
[5044/5696] Building CXX object Detectors/TPC/calibration/CMakeFiles/O2lib-TPCCalibration.dir/src/CalculatedEdx.cxx.o
[5045/5696] Building HIP object GPU/GPUTracking/Base/hip/CMakeFiles/O2lib-GPUTrackingHIP.dir/hipify/GPUReconstructionHIP.hip.o

Full log here.

@mcoquet642
Copy link
Collaborator

@mcoquet642 could you please have a look? Thanks!

Thanks, this also looks fine to me. Could maybe @shahor02 have a look ?

shahor02
shahor02 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, merging.

@shahor02 shahor02 merged commit a88d10c into AliceO2Group:dev Feb 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahor02 shahor02 shahor02 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aferrero2707 @alibuild @mcoquet642 @shahor02