-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIT: add MC aQC for FV0 and FDD #1741
base: master
Are you sure you want to change the base?
Conversation
Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
+async-label async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7 |
I suppose the failing test is because of the still unmerged O2 dependency AliceO2Group/AliceO2#13482 |
Hello @marslandALICE , Can you help @andreasmolander with testing this PR? @ktf , @singiamtel, can you check why I cannot access the CI tests? Thanks, Chiara |
Tested by running O2DPG_pp_minbias.sh locally according to https://github.com/AliceO2Group/O2DPG/tree/master/MC#adding-qc-tasks-to-the-simulation-script with my new enabled QC tasks and with my O2 changes. I passed an own argument with --qcdbHost to the o2dpg_sim_workflow.py script and uploaded the QC results successfully to a local instance of ccdb. |
@singiamtel, now I can see the logs! @sawenzel , the errors are: {code} any idea what is happening? |
Hello @andreasmolander , Thanks, I will wait for some feedback by Sandro about the CI, but on Monday I will merge anyway, since the error I see is not related to your PR, unless I am wrong. Chiara |
The problems with failing test scripts (missing --interactionRate) should be gone. |
Hello @andreasmolander , PR AliceO2Group/AliceO2#13482 was closed. What about this one? It fails I guess because the one in O2 is missing. Chiara |
Hi @chiarazampolli, It was closed due to inactivity. It should still be merged. I'll check that AliceO2Group/AliceO2#13482 can still be merged and then reopen it. This PR is also still to be merged. |
PR AliceO2Group/AliceO2#13979 replaces the old closed dependency. I.e. that new O2 PR is needed for this PR to work |
+async-label !async-2022-pp-apass7, !async-2023-pbpb-apass4, !async-2023-pp-apass4, !async-2024-pp-apass1 |
+async-label async-2024-pbpb-apass4, async-2024-pp-cpass0, async-2024-pp-apass7, async-2024-pp-apass1, async-2023-pbpb-apass3, async-2023-pp-apass4 |
Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3 |
+async-label async-2023-pbpb-apass4, async-2022-pp-apass7, async-2024-PbPb-apass1, async-2024-ppRef-apass1 |
Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!