Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIT: add MC aQC for FV0 and FDD #1741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreasmolander
Copy link
Contributor

Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!

Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!
Copy link

github-actions bot commented Sep 5, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@andreasmolander
Copy link
Contributor Author

+async-label async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass3 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 labels Sep 5, 2024
@andreasmolander
Copy link
Contributor Author

I suppose the failing test is because of the still unmerged O2 dependency AliceO2Group/AliceO2#13482

@chiarazampolli
Copy link
Collaborator

Hello @marslandALICE ,

Can you help @andreasmolander with testing this PR?

@ktf , @singiamtel, can you check why I cannot access the CI tests?

Thanks,

Chiara

@andreasmolander
Copy link
Contributor Author

Tested by running O2DPG_pp_minbias.sh locally according to https://github.com/AliceO2Group/O2DPG/tree/master/MC#adding-qc-tasks-to-the-simulation-script with my new enabled QC tasks and with my O2 changes. I passed an own argument with --qcdbHost to the o2dpg_sim_workflow.py script and uploaded the QC results successfully to a local instance of ccdb.

@chiarazampolli
Copy link
Collaborator

@singiamtel, now I can see the logs!

@sawenzel , the errors are:

{code}
10-o2dpg_sim_workflow: Error! Interaction rate not >0 !!!
{code}

any idea what is happening?

@chiarazampolli
Copy link
Collaborator

Tested by running O2DPG_pp_minbias.sh locally according to https://github.com/AliceO2Group/O2DPG/tree/master/MC#adding-qc-tasks-to-the-simulation-script with my new enabled QC tasks and with my O2 changes. I passed an own argument with --qcdbHost to the o2dpg_sim_workflow.py script and uploaded the QC results successfully to a local instance of ccdb.

Hello @andreasmolander ,

Thanks, I will wait for some feedback by Sandro about the CI, but on Monday I will merge anyway, since the error I see is not related to your PR, unless I am wrong.

Chiara

@sawenzel
Copy link
Contributor

The problems with failing test scripts (missing --interactionRate) should be gone.

@chiarazampolli
Copy link
Collaborator

Hello @andreasmolander ,

PR AliceO2Group/AliceO2#13482 was closed. What about this one? It fails I guess because the one in O2 is missing.

Chiara

@andreasmolander
Copy link
Contributor Author

Hello @andreasmolander ,

PR AliceO2Group/AliceO2#13482 was closed. What about this one? It fails I guess because the one in O2 is missing.

Chiara

Hi @chiarazampolli,

It was closed due to inactivity. It should still be merged. I'll check that AliceO2Group/AliceO2#13482 can still be merged and then reopen it. This PR is also still to be merged.

@andreasmolander
Copy link
Contributor Author

PR AliceO2Group/AliceO2#13979 replaces the old closed dependency. I.e. that new O2 PR is needed for this PR to work

cc @chiarazampolli

@andreasmolander
Copy link
Contributor Author

+async-label !async-2022-pp-apass7, !async-2023-pbpb-apass4, !async-2023-pp-apass4, !async-2024-pp-apass1

@github-actions github-actions bot removed async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 labels Feb 18, 2025
@andreasmolander
Copy link
Contributor Author

+async-label async-2024-pbpb-apass4, async-2024-pp-cpass0, async-2024-pp-apass7, async-2024-pp-apass1, async-2023-pbpb-apass3, async-2023-pp-apass4

@github-actions github-actions bot added async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Feb 18, 2025
Copy link

Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3

@andreasmolander
Copy link
Contributor Author

+async-label async-2023-pbpb-apass4, async-2022-pp-apass7, async-2024-PbPb-apass1, async-2024-ppRef-apass1

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-PbPb-apass1 async-2024-ppRef-apass1 labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-PbPb-apass1 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 async-2024-ppRef-apass1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants